Re: [Nano-devel] [PATCH] add an "atends" configuration setting

[Benno Schulenberg]

Op 30-04-18 om 22:17 schreef address@hidden:
> When towordends is set and Ctrl+Right or Shift+Ctrl+Right is pressed,
> nano will stop at the ends of words instead of their beginnings.

Thanks.  Looks better.

Five things, though:

1) Your webmailer mutilates the patch: it hardwraps long lines and
changes leading spaces to double spaces.  Please send patches as
an attachment, or better: with git send-email.

2) The changed Ctrl+Right behavior should also occur at the prompt.

3) The intermediate seen_space variable is superfluous for the new
code.  This part can be reduced to:

      if (is_word_mbchar(openfile->current->data + openfile->current_x,
                          allow_punct))
          seen_word = true;
      else if (seen_word)
           break;

4) If the option is not present in tiny nano, then the code should
be neither.  For this, it will be easier to invert the condition of
the 'if', so that the new (ifndeffed) code comes first.  (Warnings
about an unused parameter in the tiny version are acceptable.)

5) I don't like '--towordends' either.  In my ears '--afterends'
sounds better, because even just the word "after" already says
enough.  And it leaves it open whether this option will apply to
Ctrl+Down too later on.

Benno

signature.asc
Description: OpenPGP digital signature