|
From: | Benno Schulenberg |
Subject: | Re: [Nano-devel] [PATCH] Fix segfault when executing an empty command in a new buffer |
Date: | Sat, 28 Oct 2017 12:47:43 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Op 27-10-2017 om 19:09 schreef Marco Diego Aurélio Mesquita:
The attached patch fixes a segfault when creating a new empty buffer. To reproduce the bug, start nano, hit ^R ^X M-F Enter. Behavior maybe different depending on the architecture you're running. The defect was introduced in c8363a0d.
Thanks for finding that. However, I do not like the fix. All other calls of update_history() avoid making the call when the string is empty. And in this case that is the better option, because it is also pointless to *execute* the command when it is empty. So I have pushed a fix to that effect: 84c650b8. Benno
[Prev in Thread] | Current Thread | [Next in Thread] |