Re: [Nano-devel] a problem with tabs after the overhaul

[Benno Schulenberg]

On Fri, Mar 17, 2017, at 21:12, David Ramsey wrote:
> In integer arithmetic, 72 / 75 is zero, and 72 % 75 is zero as well.

Ehm... 72 % 75 is 72.  It is 75 % 75 that is zero.  And 78 % 75 is 3.

> 5. gdb will break on do_down().  was_column is set to xplustabs(), which
> is 0; leftedge is set to the beginning of the chunk was_column is on,
> which is 0;

This is where the mistake is.  leftedge should instead be set to the
beginning of the chunk that placewewant is on.  Yes, this means that
when doing Up or Down in softwrap mode, the placewewant *does* have
to be updated.  See attached patch for a rough attempt (just for Up
and Down; PgUp and PgDown will probably need something similar).

Is there anything wrong with this method?  Where does it break down?

Benno

-- 
http://www.fastmail.com - Choose from over 50 domains or use your own

use-pww-instead-of-xpt-for-up-and-down.patch
Description: Text Data