[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] Comment/Uncomment feature patch
From: |
Mike Scalora |
Subject: |
Re: [Nano-devel] Comment/Uncomment feature patch |
Date: |
Tue, 17 May 2016 06:28:55 -0600 |
On Mon, May 16, 2016 at 12:42 PM, Benno Schulenberg
<address@hidden> wrote:
>
>> > > How can a line not be commentable? Isn't this case already handled
>> > > by the 'if (strlen(comment_seq) == 0)' above? Or is this just for
>> > > the magic line?
>> >
>> > Yes, the magic line case is the only one I know of.
>>
>> I think I would prefer a different solution: just comment
>> the magic line and add a new one.
>
> Maybe this is not a good idea. If it complicates things, then just
> forget it.
I'm glad you changed your mind about that. I didn't think it was a
good idea but I wasn't sure if I had a good reason except an opinion
about user expectation. It would also make undo/redo more complicated.
> Other small problem Run 'src/nano +69 README', then type:
> M-3 M-3
> M-4 M-4
> M-U M-U M-U M-U
>
> See how always the cursor is on the C of "Current".
> Now do:
> M-E M-E M-E M-E
>
> See how the cursor is first on the last of the hashes,
> then on the u of "Current". That shouldn't be so. It
> should stay on the C.
Fixed. I thought this was going to be painful but it turns out I just
had to be mindful of when I was time traveling forward or backwards
and order the changes correctly.
-Mike
0001-Add-new-comment-and-uncomment-feature-5.patch
Description: Binary data
- Re: [Nano-devel] Comment/Uncomment feature patch, (continued)
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/03
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/08
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/10
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/10
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/11
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/12
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/15
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/15
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/15
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/16
- Re: [Nano-devel] Comment/Uncomment feature patch,
Mike Scalora <=
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Frysinger, 2016/05/17
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/17
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Frysinger, 2016/05/17
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/18
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/18
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/19
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/19
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/19
- Re: [Nano-devel] Comment/Uncomment feature patch, Mike Scalora, 2016/05/20
- Re: [Nano-devel] Comment/Uncomment feature patch, Benno Schulenberg, 2016/05/21