[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] interrupting contiguous cuts with a toggle
From: |
Mark Majeres |
Subject: |
Re: [Nano-devel] interrupting contiguous cuts with a toggle |
Date: |
Sat, 14 Jun 2014 09:03:41 -0700 |
Benno,
I didn't realize that undo/redo was no longer an option, that's great news.
Without the check for ISSET(UNDOABLE), having the cutbuffer_reset() in
nano.c will negate the call that is made in text.c
I think all the problems you mention about the ^K's and the segfault
can be resolved by leaving the call to cutbuffer_reset() in text.c per
my patch, and instead removing the cutbuffer_reset() from nano.c.
Have you tried this?
--Mark Majeres
On 6/14/14, Benno Schulenberg <address@hidden> wrote:
>
> On Fri, Jun 13, 2014, at 18:57, Mark Majeres wrote:
>> Have a look at this patch. The behavior will be different when
>> undo/redo is enabled.
>
> Hmm... No, this doesn't do anything for me. A ^C still breaks
> a series of ^Ks and loses the first part of the series.
>
> You will have noticed that since revision 4964 the undo code
> is enabled by default. Thanks to your work. :)
>
> Your patch thus adds only a call to cutbuffer_reset() in a place
> that doesn't seem to matter to me. What I think would be needed
> is that the cutbuffer_reset() routine creates or updates or closes
> an undo item.
>
> Benno
- Re: [Nano-devel] interrupting contiguous cuts with a toggle, Mark Majeres, 2014/06/12
- Re: [Nano-devel] interrupting contiguous cuts with a toggle, Benno Schulenberg, 2014/06/13
- Re: [Nano-devel] interrupting contiguous cuts with a toggle, Mark Majeres, 2014/06/13
- Re: [Nano-devel] interrupting contiguous cuts with a toggle, Benno Schulenberg, 2014/06/14
- Re: [Nano-devel] interrupting contiguous cuts with a toggle,
Mark Majeres <=
- [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Benno Schulenberg, 2014/06/14
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Mark Majeres, 2014/06/14
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Mark Majeres, 2014/06/14
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Mark Majeres, 2014/06/14
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Mark Majeres, 2014/06/15
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Benno Schulenberg, 2014/06/15
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Mark Majeres, 2014/06/15
- Re: [Nano-devel] interrupting contiguous cuts (or not) with horizontal movement, Benno Schulenberg, 2014/06/15
- [Nano-devel] the difficulties of behaving similar, Benno Schulenberg, 2014/06/17
- Re: [Nano-devel] the difficulties of behaving similar, Mark Majeres, 2014/06/18