[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] what to do when makeinfo is missing?
From: |
Mike Frysinger |
Subject: |
Re: [Nano-devel] what to do when makeinfo is missing? |
Date: |
Thu, 03 Apr 2014 10:09:54 -0400 |
User-agent: |
KMail/4.12.3 (Linux/3.13.0; KDE/4.12.3; x86_64; ; ) |
On Wed 02 Apr 2014 22:46:14 Benno Schulenberg wrote:
> On Wed, Apr 2, 2014, at 11:22, Mike Frysinger wrote:
> > i think gating the subdir and leaving the doc/texinfo/Makefile intact is
> > simpler. it's also slightly faster because then you don't have to
> > recurse.
> >
> > --- a/doc/Makefile.am
> > +++ b/doc/Makefile.am
>
> Applied in a slightly different form. Thanks.
>
>
> By the way, configure.ac contains this section:
>
> # if test x$CURSES_LIB_NAME = xcurses; then
> [...]
> #fi
>
> It somehow doesn't look right to me. What's up with it?
i think it was meant to be self documenting ... it's the last/default case, so
the assumption is that the only result left to test is plain curses. would
probably have been better to just use a real comment at that point :).
what i find really weird are these constructs:
if eval "test x$CURSES_LIB_NAME = x"; then
why the eval ?
then again, i think the entire body starting at the slang check to be pretty
bad, but i haven't gotten up the courage to gut it all.
-mike
signature.asc
Description: This is a digitally signed message part.