[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] Colorize the menu, title bar, and status bar
From: |
Mark Majeres |
Subject: |
Re: [Nano-devel] Colorize the menu, title bar, and status bar |
Date: |
Fri, 28 Mar 2014 00:06:07 -0700 |
I don't see the unnecessary changes in parse_color_string. I mostly
cut and pasted that code from parse_colors. I replaced the cut lines
with a call to parse_color_string. I also call parse_color_string in
set_colorpairs. When the function is called from set_colorpairs the
check for 'bright' is not needed. I can add a bool to the function
call and skip the check. It will add a byte or two though, and I
don't see any harm in running the check. Let me know if I am
overlooking something.
On 3/27/14, Chris Allegretta <address@hidden> wrote:
> On 3/27/14, Benno Schulenberg <address@hidden> wrote:
>>
>> On Wed, Mar 26, 2014, at 15:07, Mark Majeres wrote:
>>> Attached is a patch for v2.3.2 that adds optional colors to the menu,
>>> title bar, and status bar.
>>
>> Nice! I use a terminal with a light background, so I've set this:
>>
>> set titlecolor black,yellow
>> set focuscolor white,blue
>> set menucolor yellow
>>
>> Ochre and blue... Not bad. :)
>>
>> Is this patch something we want to include? Chris? Others?
>
> I do like this; it adds pizzazz and I have no problem with people
> being able to turn this on. That said I don't think it's something
> that the standard syntax highlighting files (e.g. c, python, etc)
> should enable; I think people users the titlebar etc to be the same
> color as their terminal's foreground. It really seems like it should
> be set system wide or not at all IMO but am interest in the use cases
> people might have for more per syntax.
>
> Some of the changes in parse_color_string() are unnecessary and are
> clouding the readability of the changes. I'd ask that changes like
> this please stick to just what needs to be changed, to make tracking
> down bugs later more easy.
>
> In general I do like it though, would you be willing reduce the
> changes to parse_color_string?
>
- [Nano-devel] Colorize the menu, title bar, and status bar, Mark Majeres, 2014/03/26
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Benno Schulenberg, 2014/03/27
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Dirkjan Ochtman, 2014/03/27
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Mike Frysinger, 2014/03/27
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Chris Allegretta, 2014/03/27
- Re: [Nano-devel] Colorize the menu, title bar, and status bar,
Mark Majeres <=
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Dan Mahoney, 2014/03/27
- Re: [Nano-devel] Colorize the menu, title bar, and status bar, Benno Schulenberg, 2014/03/27