Re: [Nano-devel] [PATCH] enable -Wall when available by default

[Eitan Adler]

On 23 March 2014 13:57, Mike Frysinger <address@hidden> wrote:
> The current code doesn't build with any warning flags which allows
> for issues to silently creep in.
> ---
>  configure.ac                |  3 ++
>  m4/ax_check_compile_flag.m4 | 74 
> +++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 77 insertions(+)
>  create mode 100644 m4/ax_check_compile_flag.m4
>
> diff --git a/configure.ac b/configure.ac
> index 87336f6..5f2c63e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -432,6 +432,9 @@ fi
>
>  dnl Checks for typedefs, structures, and compiler characteristics.
>
> +dnl Checks for available flags.
> +AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="$CFLAGS -Wall"], [], [])

Perhaps we want -Wextra as well?
Is the code -Wall -Wextra clean? I haven't checked in a bit.  If it
is, we probably want -Werror as well.

-- 
Eitan Adler