Re: [Nano-devel] another minor patch update

[David Lawrence Ramsey]

David Benbennick wrote:
>You've changed all of them.  Is there something wrong with static
>functions?  The static keyword signals that the function is local,
>specialized.  Using static when possible helps encapsulate the code.
>
>There is an off-by-one bug in do_wrap(), that means it fails to wrap
>a line that is exactly one character too wide.  The attached patch fixes
>this problem.
>
>Also, in nano.c,v 1.267 DLR added a fix for checking spelling with the
>alternate speller with the mark set.  Then in v 1.270 I foolishly took
>that fix out.  Sorry.  The attached patch adds it back.

Okay; I was a bit confused about the statics.  I've reverted
most of them; the removal of the one prototype in winio.c is
still done, however, since Chris can't stand prototypes in
.c files.  I've also merged your minor fixes in (including
your earlier fix for justification on the magicline).  Btw,
thanks for catching the dropped spelling fix.

http://pooka_regent.tripod.com/patches/nano/nanobits3-patch.txt

I've noticed two cosmetic bugs, as well.  They can both be
reproduced by doing the following:

1. Create a file containing two lines (actually, 3, counting
the magicline at the end), long enough that the last
character on each line is on the last column of the
terminal.

2. Go to the first column of the first line of the file,
turn marking on, and press the down arrow twice, so that the
cursor is on the magicline.

3. The first bug can be seen now; the last character of the
first line is not highlighted.  (Note that with the screen
display rewrite in quote29.diff applied, this problem
doesn't occur.)

4. Press the left arrow once, so that the cursor is on the
last character of the second line; the second bug can be
seen now.  The entire terminal row, past the end of the
line, will be highlighted if using rxvt 2.6.4 or aterm
0.4.2 (but not xterm); a full refresh via Ctrl-L will fix
it, though.


_____________________________________________________________
Sluggy.Net: The Sluggy Freelance Community!

_____________________________________________________________
Promote your group and strengthen ties to your members with address@hidden by 
Everyone.net  http://www.everyone.net/?btn=tag