Re: [Monotone-devel] [bug #30065] MAXPATHLEN breaks builds on GNU/Hurd

[Francis Russell]

On 27/03/12 19:12, Richard Levitte wrote:

> I have made a change locally, haven't pushed it yet...  it does
> compile, but considering it's code that only gets called for AF_LOCAL
> and monotone never deals with that kind of socket, it really has no
> impact...  which is a bit scary.

I guess that means if it's broken it won't have any bad effects :)
More seriously, perhaps it should be removed entirely then? I note that
grepping the source shows multiple references to AF_LOCAL and there
appears to be a reference to some type of 'local:' URL scheme?
Presumably monotone did support this at some point?

Reading that code made me slightly nervous anyway. In particular the way
getcwd failing isn't considered an error condition regardless of why it
failed.

> Anyway, I'll push it, but with a big fat warning.

Thanks, though I'm not quite sure that diff is what I had in mind ;)

Francis