Re: [Monotone-devel] [ANN] monotone 0.43 released

[Jack Lloyd]

On Thu, Mar 26, 2009 at 11:53:10AM +0000, Phil Hannent wrote:
> Where it defines:
> 
> char buf[len+1];
> 
> If I convert this to:
> 
> char* buf = new char[len+1];

This will leak memory, though. Using std::vector to hold buf should
also work. A patch is attached.

> It works, however the next message I get is:
> 
> Error 147     error C3416: 'dump' : an explicit specialization may not be
> explicitly instantiated       
> c:\buildbot\monotone-0.43.tar\monotone-0.43\vocab.cc
> 190   tester
> 
> on this line:
> 
> template void dump(rsa_pub_key const&, string &);

I could not find this function being specialized anywhere in the
source, and simply commenting out the specialization seemed to work OK
with GCC.

-Jack

no_vla_in_mkstemp.patch
Description: Text document