Re: [Monotone-devel] mtn rename --guess

[Matthew Nicholson]

Timothy Brownawell wrote:
> On Mon, 2009-01-26 at 22:29 -0600, Matthew Nicholson wrote:
> > Greetings,
> >
> > My rename --guess work from the mini summit is ready for testing and 
> > review.  It can be found in the net.venge.monotone.rename-guess branch.
> >
> > The rename --guess command attempts to match files in the mtn ls missing 
> > list with files in the mtn ls unknown list. Currently the command will 
> > detect renames of identical files and renames of directories composed of 
> > identical files.  Future improvements may include, renames of files and 
> > directories with partial content changes.
>
>
> #
> # patch "cmd_ws_commit.cc"
> #  from [f19eb71e76506b5ac8a706f610e6a34b595266a1]
> #    to [b3bd3a32ee59af9edb595e9c999e937390b9965b]
> # 
> # patch "options_list.hh"
> #  from [05705dd75c2e3556f4bac136b13c802d85827e0d]
> #    to [54a563f0f12bd6db64856d316d0c7a13cd0125e4]
> # 
> # patch "work.cc"
> #  from [b005a944d5e5ebcbfed43ac742871eba7d5e7ad0]
> #    to [4b549d6bcb26d3e0632b08d16871195016a66e17]
> # 
> # patch "work.hh"
> #  from [cd117c8295b2bdf48db35e92aaf29842c27a1b7f]
> #    to [066d38ca737363f32bfe4b4811689d09ee5066d8]
> #
>
> Should have at least one file like tests/<something>/__driver__.lua .

Yeah, there are several cases I have thought of to test, just haven't 
gotten around to writing the tests.

> -    options::opts::bookkeep_only)
> +    options::opts::bookkeep_only | options::opts::guess)
>
> Later it looks at app.opts.exclude_patterns and app.opts.depth, but it
> won't accept these options. It should also complain if these are given
> without the --guess option.

Ok, I'll take a look at that.

> -       "SRC1 [SRC2 [...]] DEST_DIR"),
> +       "SRC1 [SRC2 [...]] DEST_DIR\n"
> +       "--guess"),
>
> I'm thinking that should probably be "[PATH]... --guess" to be more
> consistent with other commands that take a restriction.

Ok.

> Trying it out...
>
> $ ../nvm.rename-guess/build/mtn rename --guess
> mtn: renaming a to d in workspace manifest
> mtn: warning: a doesn't exist in workspace and d does, skipping
> filesystem rename
>
> It really doesn't need to warn about that, should probably do like
> --bookkeep-only.

Yeah.  That makes sense.  I have just been ignoring those warnings :).

Thanks for the feedback.

--
Matthew Nicholson
matt-land.com