Re: [Monotone-devel] Re: more on commit without -b option

[Derek Scherger]

On Sun, Jan 18, 2009 at 3:56 PM, Thomas Keller <address@hidden> wrote:

Yes, it is a nice approach and it also prevents mistakes like
accidentally putting a revision into the wrong branch and pushing it; I
guess this is something which not only newbies could suffer from, but
also scatterbrained people like me ;)

I have another idea on how we might want to handle commit options. At the moment commit accepts --author, --branch, --date and --message options to specify  values for various certs. Once you have a committed revision, log shows it something like this:

--------------------------------------------
Revision: ...
Ancestor: ...
Author: ...
Date: ...
Branch:...

Changelog:

...
--------------------------------------------

When commit opens your editor to write a changelog maybe it should load the buffer with something that looks a *lot* like a committed revision as listed by log. Then, you not only get to see the Ancestor, Author, Date and Branch values of your pending commit but you could also *edit* them before saving the log and actually doing the commit. This essentially changes the format of messages coming back from the commit hook and requires them to have some structure. After getting the message from the hook it would be parsed and the various values would be used for their respective certs.

One other thing that would be nice to work into the format above is a clear and obvious way to say "please cancel this commit". This could be described in comment lines outside of the ---------- lines or something.

The --author, --date, and --branch options still make sense, they're just used earlier, to set initial values of the header lines in the editor buffer.

Cheers,
Derek