[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] update and other commands vs missing files
From: |
Stephen Leake |
Subject: |
[Monotone-devel] update and other commands vs missing files |
Date: |
Wed, 18 Jun 2008 03:56:48 -0400 |
User-agent: |
Gnus/5.1008 (Gnus v5.10.8) Emacs/22.2 (windows-nt) |
Why does 'update' care if some files are missing? They will be
restored or not as appropriate by the update anyway.
The warning is reported from
workspace::update_current_roster_from_filesystem. I can see that in
some situations, it would be appropriate to abort if
update_current_roster_from_filesystem detects missing files. But in
the particular case of 'update', it just gets in the way of what the
user needs.
Other uses of update_current_roster_from_filesystem:
CMD_AUTOMATE(get_current_revision)
'missing' files should show as deleted; should not abort
CMD_AUTOMATE(get_manifest_of)
'missing' files should simply not be listed; should not abort
cmd_diff_log.cc prepare_diff
'missing' files should be shown as 'only in other'; should not
abort
CMD(changed)
'missing' files should show as deleted; should not abort
CMD(merge_into_workspace)
'missing' files were probably removed by the user to resolve
conflicts. On the other hand, it might be important to see any
conflicts. So this command probably needs a user flag to enforce
or suppress the check on missing files.
Or maybe it should just be the same as 'update'
CMD(pluck)
same as 'update', or 'merge_into_workspace'
CMD(get_roster)
'missing' files should show as deleted; should not abort
CMD(status)
'missing' files should show as missing; should not abort
CMD(commit)
should abort, unless missing files are excluded from the commit
work.cc workspace::has_changes
should return true, not abort
workspace::maybe_update_inodeprints
might make sense to abort; depends on where it is called from. If
it doesn't abort, the loop that updates the inodeprints has to
be improved to handle missing files.
--
-- Stephe
- [Monotone-devel] update and other commands vs missing files,
Stephen Leake <=