monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] tests/automate_get_workspace_root broken on MinGW


From: Richard Levitte
Subject: Re: [Monotone-devel] tests/automate_get_workspace_root broken on MinGW
Date: Sun, 25 May 2008 11:24:39 +0200 (CEST)

In message <address@hidden> on Sun, 25 May 2008 01:34:18 -0400, Stephen Leake 
<address@hidden> said:

stephen_leake> >> Anyway this seems simpler:
stephen_leake> >> 
stephen_leake> >> check(cwd .. '\n' == readfile("stdout"))
stephen_leake> >> 
stephen_leake> >> Is there a reason to prefer 'qgrep' over ' == readfile()'?
stephen_leake> >
stephen_leake> > For automate we generally want *exact* output, so readfile() 
is more
stephen_leake> > correct. qgrep would be more for checking non-automate 
commands, which
stephen_leake> > tend to have pretty formatting and human-targeted extra 
chatter that's
stephen_leake> > OK to change.
stephen_leake> 
stephen_leake> Ok, that's what I thought. My fix is committed.

Some day, I will learn to read through all my mail before I respond...

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis




reply via email to

[Prev in Thread] Current Thread [Next in Thread]