[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] problem with tester on WIN32 MinGW
|
From: |
Stephen Leake |
|
Subject: |
Re: [Monotone-devel] problem with tester on WIN32 MinGW |
|
Date: |
Thu, 30 Aug 2007 20:08:41 -0400 |
|
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (windows-nt) |
"Zack Weinberg" <address@hidden> writes:
> On 8/30/07, Stephen Leake <address@hidden> wrote:
>>
>> Should I commit that change in tester.cc posix_umask, or is there a
>> better solution? I think 'umask' isn't meaningful on Win32.
>
> Yes, please commit the change to posix_umask. It is indeed not
> meaningful on Win32, and it is supposed to be a no-op there, so we
> don't have to have #ifdefs in the higher layers.
>
> It'd be nice if you could commit the more detailed error message change too.
>
Ok, done.
--
-- Stephe