Re: [Monotone-devel] 216 invalid_--root_settings FAIL (line 13)

[Thomas Keller]

Thomas Keller schrieb:
> So, if your workspace is somewhere under /tmp and you set --root to
> /tmp, this means that it stops there, but at this point it already found
> the _MTN directory in
> /tmp/release/mtn/tester_dir/invalid_--root_settings. As this test wants
> to let the search fail (at least this is what I understood, one may
> correct me here at any time), we need to make sure that it stops
> earlier. The best way to do this is imho creating a new tmp dir in the
> tester dir, cd to it and --root to it. Then we should be safe from any
> "side effects" which should make this test fail.

Hrm, ignore me. This is actually tested one line below the currently
tested directory. Is this test "workspace outside of root" really
needed? How can we ever assure that any root we enter there is not also
the root from which the test _may_ be executed? The only thing which
comes into my mind is to create a temp directory under /tmp, restrict to
that, test and remove it afterwards.

Thomas.

-- 
only dead fish swim with the stream: http://thomaskeller.biz/blog
Am Anfang war das Wort: http://www.schäuble-muss-weg.de

signature.asc
Description: OpenPGP digital signature