monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] Speeding up automate stdio


From: Nathaniel Smith
Subject: Re: [Monotone-devel] Speeding up automate stdio
Date: Fri, 3 Aug 2007 10:15:48 -0700
User-agent: Mutt/1.5.13 (2006-08-11)

On Fri, Aug 03, 2007 at 01:59:10PM +0200, Patrick Georgi wrote:
> With that change, it took only 4 minutes on tmpfs, and feeling more 
> courageous, I removed the transaction guards in put_file (there's a big 
> one around it, after all), which gave another 30 seconds.

This last part sounds like a bug -- transaction guards are supposed to
nest, so that if we are already in a transaction all that they should
do is increment a variable somewhere.

Fixing this would help with some of your later concerns about removing
transaction guards as well, since there should never be any reason to
remove a transaction guard...

You might also want to look into the "checkpoint" (IIRC it's called
that) functionality, if you're thinking about automate stdio and
transactions.

-- Nathaniel

-- 
So let us espouse a less contested notion of truth and falsehood, even
if it is philosophically debatable (if we listen to philosophers, we
must debate everything, and there would be no end to the discussion).
  -- Serendipities, Umberto Eco




reply via email to

[Prev in Thread] Current Thread [Next in Thread]