[Monotone-devel] [PATCH] Make --execute default

[William Uther]

Hi all,

  I've just finished a patch to make --execute the default.   
Actually, it entirely removes the --execute option, and adds a new  
option --bookkeep-only which is approximately the inverse of -e.   
This also adds some checks to the drop implementation so that if you  
try to drop a changed file (or a dir that isn't empty when it gets to  
it) then it noisily falls back to --bookkeep-only.  This patch also  
changes rename so that it warns when you're moving something and the  
source is missing but the destination exists - it used to just  
silently fall back to --bookkeep-only in that case.

  I've also fixed all the tests to make this work.  ugh.  They all  
pass now (except for ws_ops_with_wrong_node_type which didn't pass  
before and probably shouldn't be passing.  I think changing monotone  
so it passed would be a mistake - the broken part of the test should  
be removed).  In most cases I did the simple fix of just removing "- 
e" or adding "--bookkeep-only", even when there was a move with "-- 
bookkeep-only" followed immediately by a rename.  I wanted to be  
conservative with the test suite.

  The test restrictions_with_renames_and_adds was also failing  
before this patch.  I fixed it so it passes.

  I tried sending the patch to the list, but it was too large (the  
meat of the patch is fairly small, but there were a lot of tests to  
fix up).  I've put it on the web (with my other monotone patches) here:

http://www.cse.unsw.edu.au/~willu/monotone-patches/

Specifically:

http://www.cse.unsw.edu.au/~willu/monotone-patches/mtn_execute.patch

Be well,

Will       :-}