[Monotone-devel] [PATCH] mtn automate set_option

[Ben Walton]

Hi All,

I cooked this up today as a corollary to get_option.  I hope it's useful.

There is one thing that I didn't do that I wanted to inquire about.
Currently, there is no way to clear an old option using
set_ws_options, as a new empty string prompts the function to use the
old value if there was one.

I'd like to suggest adding a boolean flag to set_ws_options
(defaulting to true) that allows an interface to clear a value.  The
reasoning I have is that currently, if you set the keydir to a new
location which doesn't have the currently set key value there, you're
allowing an inconsistent options file to be created.  Although an
order of operations from the interface driving the automation can work
around this, I personally think it would be better to clear the key
option if it become invalid.

If you think the modification to set_ws_options is an ok idea, I can
do that and resubmit a patch encompassing that change too.

Thoughts?

Current ChangeLog Entry:
2006-12-21  Ben Walton       <address@hidden>
 * automate.cc: added set_option.
 * monotone.texi: documented 'automate set_option'

Thanks
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <address@hidden>

Unanswered questions are far less dangerous than unquestioned answers.
- The Roadside Pulpit
---------------------------------------------------------------------------------------------------------------------------

mtn_automate_set_option.diff
Description: Binary data