Re: [Monotone-devel] [PATCH] mtn mkdir quickie

[Thomas Keller]

Hi Ben!

Thanks a lot for your patch. I'm not the one who reviews and adds it 
(though I looked over it and it seems to be fine for me), just two 
little hints for your next patch:

a) try to revert po/*.po files before you commit - unfortunately these 
are always changed when you build but do not contain any reasonable 
changes. usually a mtn revert po/*.po will do the trick

b) this may be more a question of someone's taste, but it also might 
simplify your work - I'm speaking of the splitted tests which mostly 
only contain a few lines of code. again, this might be perfectly ok for 
others, but I personally always like similar things a little bit coherent.

Thanks again for your work!

Thomas.

--
ICQ: 85945241 | SIP: 1-747-027-0392 | http://www.thomaskeller.biz
> Guitone, a frontend for monotone: http://guitone.berlios.de
> Music lyrics and more: http://musicmademe.com