[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Bug/patch: automate stdio
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] Bug/patch: automate stdio |
Date: |
Tue, 28 Nov 2006 10:27:19 -0800 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Tue, Nov 28, 2006 at 12:05:02PM -0600, Timothy Brownawell wrote:
> On Sat, 2006-11-25 at 20:40 +0100, Christian Ohler wrote:
> > There's a pretty serious bug in automate stdio in mtn 0.31 and mainline.
> > Under certain circumstances, mtn gets confused reading its input and
> > processes a command that is different from what was sent on stdin.
> >
> > I believe the attached (one-line) patch fixes this. Unfortunately, I
> > see no easy way for me to provide a test case for this.
>
> Patch applied, thanks. And yeah, it'd be a bit of a pain to write a test
> for.
I suppose we'd have to write some sort of mock iostream, that fed us
bytes with random blocksizes? I think I've seen this done (in the
twisted testsuite), but ugh...
-- Nathaniel
--
Electrons find their paths in subtle ways.