[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Netsync performance improvement patch
From: |
Nathaniel Smith |
Subject: |
Re: [Monotone-devel] Netsync performance improvement patch |
Date: |
Sun, 14 Aug 2005 23:18:11 -0700 |
User-agent: |
Mutt/1.5.9i |
On Sun, Aug 14, 2005 at 10:16:59PM -0700, Eric Anderson wrote:
> > I assume that a boost::circular_buffer isn't suitable since
> > that doesn't have contiguous storage?
>
> Yes, the rest of the monotone code makes assumes that buffers are
> contigous that the various buffers are all contigous. In theory
> switching to entirely non-contigous buffers would be even better from
> a copy/memory usage standpoint, but that fix was going to be very
> invasive, and if this patch couldn't get in, one that changes way more
> seemed even less likely to get in.
This is a bit tangential, but could you give a pointer to some
examples of the code you mean? I'm just curious what you mean here.
-- Nathaniel
--
"On arrival in my ward I was immediately served with lunch. `This is
what you ordered yesterday.' I pointed out that I had just arrived,
only to be told: `This is what your bed ordered.'"
-- Letter to the Editor, The Times, September 2000