Re: [Monotone-devel] [PATCH] Include()/Includedir() lua functions, --rcfile=directory

[rghetta]

Derek Scherger wrote:
> having read that I was expecting you would have added /etc/monotonerc
> or something.
An /etc/monotone could also be useful, but I'm not sure how to handle it 
on windows.

> what's up with the big whitespace diff? personally I would prefer to see
> big reformatting patches not mixed in with functionality change patches
> just 'cuz they're kinda hard on the eyes.
Whitespace diff ? Perhaps it's the lua.cc diff ? I had to move struct 
Lua declaration to use it in my functions and the resulting diff is a 
bit difficult to read.

> also, was the change to the comment in commands.cc just to make gcc
> happy? I'm guilty of adding that comment a while ago and I do recall
> seeing a gcc warning about it. I'm surprised that I didn't clean it up
> before committing actually but I must have missed it. I'll commit a fix
> for this in another change I'm working on if you like. thanks for
> catching it, ccache has kept me blissfully ignorant I guess.
You're welcome :) It seemed small enough to slip in without remarks.

> I don't have any general feeling for whether I want these functions or
> not myself (which is in no way an objection). hopefully someone else
> will have more to say about them.
I thinks these functions are most useful when you have a number of 
developers physically attached to the same server/lan and you want to 
provide a common environment to everyone, while allowing further 
customization by the single user.
I see them also useful for providing per filetype merge/diff support as 
requested by some.

Ciao,
Riccardo