Re: [Monotone-devel] [PATCH] --msgfile commit option

[Nathaniel Smith]

On Mon, May 09, 2005 at 08:14:12AM +0200, rghetta wrote:
> This patch adds a --msgfile=<message file> commit option. The named file
> content is used as the commit message.

Two requests:
  -- make it --message-file, I guess?  Unless anyone else has a better
     idea.  It's a little verbose, but we don't have --msg either...

  -- you're not quite using the right APIs to get the data.
     "local_path" is only for files inside the working copy, and your
     code won't work right if someone passes a relative path while in
     a subdirectory of the working copy (because monotone will chdir()
     before trying to open the file).
     See OPT_RCFILE's implementation for how to handle this correctly.
     The main thing is to munge the filename immediately, before
     saving it, and then to use read_data_for_command_line later to
     actually read it.
     This should also mean --message-file=- will work automatically.

-- Nathaniel

-- 
"On arrival in my ward I was immediately served with lunch. `This is
what you ordered yesterday.' I pointed out that I had just arrived,
only to be told: `This is what your bed ordered.'"
  -- Letter to the Editor, The Times, September 2000