[Monotone-devel] Re: monotone ls unknown

[graydon hoare]

Peter Simons wrote:

>     monotone: tree walk examining MT

oh goodness, you've uncovered a rather serious bug! directory iteration 
happens in an undefined order, and we're returning rather than 
continuing when we hit book-keeping files, of which MT/ is one.

I've applied the following change to my depot. you can fetch from there 
or apply this patch by hand.

-graydon

# Old manifest: 77644615039c8758abf90c89dd144387663c1896
# New manifest: 173f63b63bf313662b4ae02fd7da6e684446b122
# Summary of changes:
#   patch ChangeLog 977b0d780d3b591642c77de060ba52410a0e4d04 -> 
f4422846831b0b3eeb82f517ee00e6e5912792be
#   patch file_io.cc c2e1972d5d89db479ace16cee809997790d5962f -> 
8f1fbcda25c2af36a861f9eca2422b4da333d45b
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,7 @@
+2003-12-16  graydon hoare  <address@hidden>
+
+       * file_io.cc (walk_tree_recursive): continue on book-keeping file.
+
 2003-12-15  graydon hoare  <address@hidden>
 
        * tests/t_unidiff.at, t_unidiff2.at: Check for mimencode.
--- file_io.cc
+++ file_io.cc
@@ -236,7 +236,7 @@
       fs::path rel_entry = relative / fs::path(entry.leaf());
 
       if (book_keeping_file (entry))
-       return;
+       continue;
 
       if (fs::is_directory(entry))
        walk_tree_recursive(entry, rel_entry, walker);