Re: [Monotone-devel] Re: stmp problems

[Magnus Therning]

On Tue, Dec 02, 2003 at 10:26:31PM -0500, graydon hoare wrote:
>Magnus Therning wrote:
>
>>It is reproducable (don't know if that's good or bad :-), simply put two
>>(one is too few, haven't tried three or more) email targets in the table
>
>yeah, thanks to the log dump you mailed me, I reproduced this, it's just 
>a small bug (missing copy constructor for a refcounted object, duh). 
>I've posted a fix to my depot, it should work now.
>
>>There are some other problems with the smtp posting as well:
>>
>> - I am not sure that assuming that the domain of the email address has
>>   an accessible server is a good thing:
>
>true enough, this ought to be more flexible, either via get_connect_addr 
>or similar. would some docs on using get_connect_addr be enough for that?

I think so. The solution isn't too difficult:

 get_connect_addr(proto, host, port)
   if( proto == "smtp" ) then
     return { "your.isp.smtp.server", 25 }
   end
 end

The MXs lookup happen anyway (lookup_mxs() is called in post_smtp_blob()
before open_connection() makes the call out to the hook).

/M

-- 
Magnus Therning                    (OpenPGP: 0xAB4DFBA4)
address@hidden
http://magnus.therning.org/

The only way to be truly creative is to never repeat yourself.
     -- Rob Breszny

signature.asc
Description: Digital signature