|
From: | Martin Pala |
Subject: | Re: patch for parsing of arguments used in the start start/stop programs modification |
Date: | Thu, 25 Jul 2002 16:25:16 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607 |
Jan-Henrik Haukeland wrote:
Martin Pala <address@hidden> writes:i've uploaded on CVS patch for support ARGMAX arguments for start/stop programs (ARGMAX is constant defined in monitor.h.in). By default 10 arguments are allowed (it should be maybe more by default ?). If the start/stop program defines more then this limit, monit will write error to the log and the spawned child will exit.Unfortunately I think there could be a problem by splitting on space only. F.ex. Statements like these will not work correctly: /bin/sh -c { echo $$ > pidfile; exec program } /bin/date "+%Z %b %e %T" The problem is to identify strings, { blocks} et cetera and paste them as _one_ argument. What do you think?
You are right - this implemetation doesn't do much more than earlier, so such commands as mentioned above are not supported correctly yet (it only extend present parser to support "standard" arguments until ARGMAX is reached).
If argument blocks should be supported (and i think they should :) submitted patch wouldn't be satisfaction for it => more extended refactoring will be needed. If the new parser wouldn't be done until new (patch) release, we can maybe use submitted patch, while it is bit better than present parser (or drop it to the hell :)
Martin
[Prev in Thread] | Current Thread | [Next in Thread] |