mldonkey-bugs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Mldonkey-bugs] [bug #17085] hdd_free checks cannot be switched off


From: spiralvoice
Subject: [Mldonkey-bugs] [bug #17085] hdd_free checks cannot be switched off
Date: Wed, 12 Jul 2006 18:44:56 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; de-DE; rv:1.8.0.4) Gecko/20060701 Firefox/1.5.0.4

Follow-up Comment #1, bug #17085 (project mldonkey):

The hdd_space_check-patch has been introduced 2006/03/19,
this is the first bug report of this kind.
I set up a CFS partition here following
http://gentoo-wiki.com/HOWTO_Encrypt_Your_Home_Directory_Using_CFS#Introduction_to_CFS
and could reproduce the bug. Because of the sensitivity of
MLDonkeys ini file saving procedure IMHO its not a good idea
to create an option to disable DriverInteractive.hdd_check ().

Here is a patch which is a work-around for the CFS-freespace problem:

diff -a -x Root -x Repository -x Tag -x Entries -x Entries.Log -x .svn -x
'*.rej' -x '*.orig' -N -r -u ./src/daemon/driver/driv
--- ./src/daemon/driver/driverInteractive.ml    2006-06-27 23:20:28.000000000
+0200
+++ ./src/daemon/driver/driverInteractive.ml    2006-07-12 18:39:02.000000000
+0200
@@ -93,6 +93,7 @@
   let dir_full dir mb =
     match Unix32.diskfree dir with
     | None -> false
+    | Some v when ((Unix32.filesystem dir = "NFS_SUPER_MAGIC") && v = zero)
-> false
     | Some v -> v < megabytes mb
   in

CFS filesystems report themselves as NFS_SUPER_MAGIC, if the
freespace is reported as zero on such a partition its ignored
in the future during hdd_space_check. Attached you will find
a patch including the patch above + a cosmetic patch for
unix32 module to prevent a Division_by_zero error in debug_disk command.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]