[Mldonkey-bugs] [bugs #7951] Problem sending mail after finished download

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #7951] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Sun 05/02/04 at 17:25 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed







/**************************************************************************/
[bugs #7951] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7951>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Mon 03/01/04 at 09:45

Category:  Core
Severity:  7 - Major
Item Group:  Program malfunction
Resolution:  Fixed
Assigned to:  None
Status:  Closed
Release:  2.5.12
Release:  2.5.12
Platform Version:  Linux
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  Problem sending mail after finished download

Original Submission:  Hi,
in commonInteractive.ml there is an assignment:
M.mail_from = Printf.sprintf "mldonkey <%s>" !!mail;

the brackets disturb the mailer of my provider (t-online), so mail gets sent my 
mlnet, but it vanishes inside t-online.

removing the <> in the above line does the trick and mailing works again.

BTW: What is the "sendmailbracket" option used for ? I've seen an other area in 
the code which also seems to deal with sending mail that honors that option


Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 03/15/04 at 00:52         By: spiralvoice
Please check if this bug still is in current CVS version.
You should find a tarball of current CVS in files section of
this project: http://savannah.nongnu.org/download/mldonkey/

-------------------------------------------------------
Date: Mon 03/01/04 at 16:55         By: spiralvoice
I have to disable add_mail_brackets with this patch, then I can send mail via 
T-Online.

-------------------------------------------------------
Date: Mon 03/01/04 at 16:38         By: spiralvoice
Please tell us if patch 2720 fixes the problem.

-------------------------------------------------------
Date: Mon 03/01/04 at 13:39         By: spiralvoice
The option add_mail_brackets should take care of this.
I say should because I think it does not.
In src/utils/net/mailer.ml, line 90-93 it says if add_mail_brackets = true then 
"MAIL FROM <%s>" else "MAIL FROM %s".
%s is a placeholder for the mail adress which is filled in commonInteractive, 
line 146, the place you have found.
And there are brackets hard coded so add_mail_brackets does nothing but add yet 
MORE brackets to MAIL FROM when sending the notification. So I think you are 
right to remove them. I will test it here and will post a patch IF I can still 
send mails in my environment (local exim), regarding other environments I will 
post a message in the dev forum on MLDonkey world...












For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=7951>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/