[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Mingw-cross-env-list] [PATCH] Various updates and a fix.
From: |
Tony Theodore |
Subject: |
Re: [Mingw-cross-env-list] [PATCH] Various updates and a fix. |
Date: |
Wed, 22 May 2013 00:26:39 +1000 |
On 22/05/2013, at 12:01 AM, Mark Brand <address@hidden> wrote:
> On Tuesday 21 May 2013 23:48:49 Tony Theodore wrote:
>> On 21/05/2013, at 11:13 PM, Mark Brand <address@hidden> wrote:
>>> […] except for the
>>> gcc fix, which the previous commit fixes in a different way.
>>
>> Wouldn't replacing the `grep` with a version sort be better? Then it doesn't
>> need to be updated again.
>
> Sort doesn't give the expected result in when comparing, for example "4.8.10"
> and "4.8.9". I think this is what originally motivated grep filters in many
> cases instead of sort.
The gnu sort `-V` option does the trick with a version sort that matches the
Debian version guidelines [1]. I added this to the requirements a while back
[1] so we can rely on it being present:
printf '4.8.10\n4.8.9' | sort
printf '4.8.10\n4.8.9' | sort -V
Cheers,
Tony
[1] http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version
[2]
http://lists.nongnu.org/archive/html/mingw-cross-env-list/2013-03/msg00073.html