|
From: | Luis Saavedra |
Subject: | Re: [Mingw-cross-env-list] including hdf5 |
Date: | Sun, 11 Mar 2012 12:45:32 -0400 |
Alois Schlögl wrote:Hi Alois,
Please include the attached file in the repo.
Thanks for this contribution. I have a few comments about it.
1) Instead of using sed to change Makefile.in, I think it would be better to supply a patch for Makefile.am, and then regenerate Makefile.in. This way it's easier to see whether patches continue to apply as expected when the package is upgraded. See gnutls.mk for an example of how to do this. Perhaps hdf5 comes with an 'autogen.sh' or similar script.
2) It would also be nice to have your change in the form of a patch that applies to the mercurial repo. You can make it using 'hg export -g'. This will contain your email address as the contributor.
3) Also please consider whether CHOST can appear at the end of the configure invocation. This is the style generally used in mingw-cross-env.
regards,
Mark
pango.patch
Description: Binary data
[Prev in Thread] | Current Thread | [Next in Thread] |