Re: [Mingw-cross-env-list] TinyXML integration

[Volker Grabsch]

Alexandre Bacquart <address@hidden> schrieb:
> So I decided to integrate it in MCE. Please see attached patch.

Thanks for the contribution and sorry for the late reply!
I just included your patch:

    http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/92ab95135d73

> - I tweaked the update rule and it worked for me (tried it with an older  
> version specified)

I changed the update rule to use the correct version number
(2.6.1 instead of 2_6_1), and convert it when needed.

I also simplified your build rules. Please have a look at my changes:

    http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/68a3251bc0e8

> - I added a test program. Most of its code has been taken from the  
> tinyxml tutorial at:
> http://www.grinninglizard.com/tinyxmldocs/tutorial0.html.
> The test program takes a xml file as argument and just parses it to  
> stdout. So yes, this is not a "strict-minimal-standalone" test, so feel  
> free to replace it with something more appropriate if needed, it should  
> be easy enough.

Indeed, it is a bit long. So I shortened it:

    http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/377f9d1ee231

> - Specific to current Debian testing repository (squeeze): regarding the  
> test program, it seems there is a little interface difference between  
> tinyxml's very last version (2.6.1) and the one available on Debian  
> queeze (2.5.3). It is about some renamed enumerations (like  
> TiXmlNode::DOCUMENT renamed in TiXmlNode::TINYXML_DOCUMENT). I wonder  
> why they did that. Anyway, I decided to simply ignore it for the purpose  
> of MCE and simply used last version names in the test program.

I think this was the right decision.

> That  
> makes the thing currently not portable without some few #ifdef in real  
> projects built on Debian (not mine, I don't use those enum :) ), but  
> only until Debian catch-up, that should not be a big deal.

Note that the test programs should be working with _future_ versions
of the library, not with ancient versions.

So that's perfectly okay, although irrelevant by now, because of
the shortening.

> - Even if tinyxml is really simple to use, it would be nice to have  
> pkg-config stuff. For instance, I don't really know how to make it  
> clean, so I left it for you guys.

The problem is that no portable application could rely on it.
So I don't think mingw-cross-env is the right position to introduce
the *.pc file. Instead, such a file should be proposed to upstream.


Greets,
Volker

-- 
Volker Grabsch
---<<(())>>---