[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Mingw-cross-env-list] [PATCH] check target
From: |
Volker Grabsch |
Subject: |
Re: [Mingw-cross-env-list] [PATCH] check target |
Date: |
Sat, 2 Oct 2010 13:59:45 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Martin Gerhardy <address@hidden> schrieb:
> i'm just trying to get mingw-cross-env compiling some libs on a windows
> system, too.
>
> for this i found it useful to check for all the needed tools.
This looks great. I also wanted to do this, but I didn't find
the time (yet). Some quick notes about what should be added
before including it:
1) Check how portable it is
a) maybe we should use `...` instead of $$()
b) I'm not sure whether "which" available on BSD systems
Maybe executing "TOOL --help" or something like that is a better
way? (This is how we check for (g)sed, (g)patch, etc)
2) Point to the docs, as missing requirements are usually the result
of not having read them. :-) It could be something like this:
echo 'Please check the "requirements" section of doc/index.html'
3) Provide a list of tools instead of a long "check" section. I could
write the corresponing "macro foo" if you like.
TOOLS = wget openssl ...
4) Maybe sort the list of tools. :-)
Greets,
Volker
--
Volker Grabsch
---<<(())>>---