[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] [patch] upgrade packages glib gtk

From: Volker Grabsch
Subject: Re: [Mingw-cross-env-list] [patch] upgrade packages glib gtk
Date: Wed, 21 Apr 2010 01:36:10 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Mark Brand <address@hidden> schrieb:
> I got these most recent versions to build and they don't seem to break 
> building other packages. I hope someone with more understanding of glib 
> and gtk will review this and check functionality.

Your patch seems to be mostly okay, but I noticed two things
that need some discussion before I can include your patch.

1)  Are the following commands really necessary?

+    $(MAKE) -C '$(1).native/gio/xdgmime' -j '$(JOBS)'
+    $(MAKE) -C '$(1).native/gio/inotify' -j '$(JOBS)'
+    $(MAKE) -C '$(1).native/gio/libasyncns' -j '$(JOBS)'

As far as I understand, these should be called automatically
when you run:

+    $(MAKE) -C '$(1).native/gio'     -j '$(JOBS)'

2)  You are enabling threading in glib:

-        --disable-threads \
+        --enable-threads \

This is generally a good thing, but caused some trouble in
the past, probably due to problems with the pthreads-w32
library. So I guess it is okay to keep that change, but it
means that we _must_ sort out the known pthreads-w32 issues
as soon as possible.

Did you try to run "test-gtk.exe" under Windows or Wine after
this change?



Volker Grabsch
NotJustHosting GbR

reply via email to

[Prev in Thread] Current Thread [Next in Thread]