Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph

[Volker Grabsch]

Martin Lambers <address@hidden> schrieb:
> On Fri, 22. Jan 2010, 01:11:10 +0100, Volker Grabsch wrote:
> >
> > Wouldn't it make more sense to put the static stuff into an #ifdef ?
> > 
> >     #ifdef OSG_LIBRARY_STATIC
> >     USE_GRAPHICSWINDOW()
> >     USE_OSGPLUGIN(<plugin1>)
> >     USE_OSGPLUGIN(<plugin2>)
> >     ...
> >     #endif
> 
> Yes, this is what I had in mind. The configure script can determine
> whether to use static or dynamic OSG, and add -DOSG_LIBRARY_STATIC to
> CPPFLAGS if necessary. The source only needs the code snippet above to
> work with both.

Okay, in that case we should revise the tutorial's "Step 5d":

|   Using static OpenSceneGraph libraries requires a few changes to
|   your source:
|
|     * Define OSG_LIBRARY_STATIC
|
|     * Use the macro USE_GRAPHICSWINDOW() to explicitly reference
|       your graphics system
|
|     * Use the macro USE_OSGPLUGIN(<plugin>) to explicitly reference
|       any plugin you might want to use

This is misleading because it suggests doing a

    #define OSG_LIBRARY_STATIC

within one's source files. It would be probably more clear
using a code snippet like the one I proposed:

    #ifdef OSG_LIBRARY_STATIC
    USE_GRAPHICSWINDOW()
    USE_OSGPLUGIN(<plugin1>)
    USE_OSGPLUGIN(<plugin2>)
    ...
    #endif

(Maybe some empty lines or some indentation need to be
added for clarity.)

Would you mind revising this section in doc/index.html
accordingly?


Greets,

    Volker

-- 
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR