[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lynx-dev] minor patch for src/LYCharSets.c

From: Mikhail T.
Subject: Re: [Lynx-dev] minor patch for src/LYCharSets.c
Date: Mon, 02 Jul 2007 19:00:54 -0400
User-agent: Thunderbird (Windows/20070604)

Thomas Dickey wrote:
On Mon, 2 Jul 2007, Mikhail T. wrote:


This is a minor patch, which makes sure, the correct entities.h is included. The file-name is common, and, depending on what else is installed on the building machine, a wrong file may be included -- as just happened on my machine. The patch makes the include more explicit:

I thought I addressed that in dev.5 (with the include-ordering).
Dunno about the dev.5 -- I was trying to build 2.8.6rel.5 and the build was failing due to entities.h installed by gd-2. Include reordering is a good idea, but using <> for your own headers is wrong, IMO. My patch offers a "bullet-proof" way of ensuring, the right header is included in this case.


--- src/LYCharSets.c    Sun Dec 18 17:52:30 2005
+++ src/LYCharSets.c    Mon Jul  2 16:10:40 2007
@@ -871,5 +871,5 @@
UCode_t HTMLGetEntityUCValue(const char *name)
-#include <entities.h>
+#include "chrtrans/entities.h"

   UCode_t value = 0;

Please, include it in the next (pre-)release. Thank you,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]