[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lynx-dev] [PATCH] DJGPP and MingW patch against 2.8.6rel.2

From: Doug Kaufman
Subject: Re: [Lynx-dev] [PATCH] DJGPP and MingW patch against 2.8.6rel.2
Date: Sun, 15 Oct 2006 23:06:54 -0700 (PDT)

On Sun, 15 Oct 2006, Thomas Dickey wrote:

> On Sun, Oct 15, 2006 at 02:28:57PM -0700, Doug Kaufman wrote:
> > 1. When the "endwin" function was added for PDCurses in LYCurses.c, the
> > code to clear the screen for DJGPP and MingW was (accidentally)
> > orphaned, so both were leaving the screen filled at exit. In trying to
> > put back the screen clearing code, I noticed that the MingW code had
> > never really worked. This attempts to fix the screen clearing problem
> > for the two platforms.
> oh.  I had thought this particular case was due to a different intent.
> Rather than requiring the screen to be cleared on exit (which is plausible),
> the code as written was attempting to clear the screen but not actually
> exit from curses.  That seemed to be because someone was avoiding some
> visual effect when spawning a short subprocess (or that they didn't like
> the convention of positioning the cursor at the lower-left).

It is hard to know what the intent was. Here is the code for stop_curses
from 2.8.1rel.2 in October 1998. This was shortly after there was any
support for the DJGPP platform, and Wayne Buttles was the main person
doing DJGPP for lynx. I think that PDCurses was much less developed
then, and I am not sure that anyone thought about endwin for DJGPP,
since the screen looked "OK". It looks like endwin was not called for
DOSPATH with PDCurses, but was called for other platforms. I can't tell
you if that was intentional or an oversight. What I can say is that the
appearance of the screen changed markedly recently when endwin was added
and clearing the screen was taken away.

PUBLIC void stop_curses NOARGS
#ifdef DJGPP
#if defined (DOSPATH) && !defined(USE_SLANG)

     *  Fixed for better dumb terminal support.
     *  05-28-94 Lynx 2-3-1 Garrett Arch Blythe
    if(LYCursesON == TRUE)      {
         lynx_enable_mouse (0);
         endwin();      /* stop curses */

#endif /* DJGPP */

    LYCursesON = FALSE;


> > 4. Per the recent discussion about being able to prevent downloading
> > and saving to disk on Win98, where users have full control, I put in a
> > define "LYNX_CRIPPLED" which, when defined at compile time, should make
> > downloading and saving to disk difficult, and with no way to override
> > this with command line arguments or settings in lynx.cfg.
> will see - thanks
> offhand though - it seems that adding a common symbol to replace the
> normal true/false in the restrictions would be less clutter than 
> ifdef's.

If it looks like you want to put the "LYNX_CRIPPLED" stuff in the main
code, let me know and I'll try to redo the TRUE/FALSE lines as you

Doug Kaufman
Internet: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]