[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lynx-dev] Re: HTTP request from USS [PATCH]

From: Thomas Dickey
Subject: Re: [Lynx-dev] Re: HTTP request from USS [PATCH]
Date: Sat, 20 Mar 2004 20:42:08 -0500 (EST)

On Sat, 20 Mar 2004 address@hidden wrote:

> In a recent note, Thomas Dickey said:
> > Date: Sat, 20 Mar 2004 15:15:04 -0500 (EST)
> >
> > two details:
> >     a) there's a typo in your patch (should be HAVE_GETATTRS, not
> >        HAVE_GETATTR), and
> >
> Oops.  Thanks!  (But it worked OK on z/OS :-).

yes - it probably works almost everywhere either way.  Most of the
color-curses implementations have getattrs() although it's not in X/Open.

(I just made a note to refine the no-extensions configuration of ncurses
so I can flush out this sort of thing).

> > Looking right now, it seems that the fix would be to remove the last
> > part of the ifdef - where it says "|| !defined(NCURSES_MAJOR_VERSION)".
> > (That would break some very old ncurses versions, but nothing else that
> > I can think of).
> >
> It's very much the convention for GNU configure to encourage testing for
> capabilities (e.g. HAVE_GETATTRS), rather than for specific system
> versions (e.g. NCURSES_MAJOR_VERSION).  I'm curious whether there's a
> rationale for reversing that convention in this case.

It was just the first solution that came to mind (sorry).  As I said, when
I was making the fix I was thinking the effect of the change would be to
make getattrs() used only for older versions of ncurses.  That last chunk
of the ifdef (goes off the screen when I've line-wrapping off) didn't
raise an issue in my mind. Probably too many late nights.  Since the
configure script does check for getattrs(), it might have made sense to
use that.

But not really.

Over in dialog I'm fussing over some places where the people at HP have
been breaking the legacy stuff - still in the namespace, but it doesn't
work the way it used to.  So the preference is to use the X/Open functions
(HP's broken less of that), and handle special cases.

Thomas E. Dickey

Lynx-dev mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]