Re: lynx-dev Possible Bug in Lynx 2.8.5-dev.15

[Thomas Dickey]

On Thu, May 01, 2003 at 03:40:50PM +0000, Patrick Ash wrote:
> On Thu, 01 May 2003 15:24:26 -0400, Thomas Dickey wrote:
> 
> >> When going to the following url, Lynx traps and exits. This occurs
> >> both when selecting the link from a main page, and starting lynx with
> >> the url as the target. 
> >> 
> >>  http://camden-sbc.rutgers.edu/FacultyStaff/Directory/default.htm
> >> 
> >> None of the other links on the main page (
> >> http://camden-sbc.rutgers.edu ) exhibit the same behavior. 
> >> 
> >> This is lynx-2.8.5-dev.15, built on OS/2 with ncurses-5.3. The
> >> behavior does not exist with dev.14 built with the same parameters. 
> >
> >The immediate problem is in TRSTable.c, where it attempts to reuse a pointer
> >which is normally malloc'd.  If you change this "0" to a "1", it should work:
> >
> >#if 0        /* Leads to no memory savings and quadratic time with EMX 
> >malloc */
> >     /* Do not need extra cells any more */
> >     me->rows[me->nrows - 2].cells = realloc(p,c * sizeof(STable_cellinfo));
> >     me->rows[me->nrows - 2].allocated = me->rows[me->nrows - 2].ncells;
> >#else
> >     if (!me->used_chunks
> >
> >The realloc is used to shrink storage requirements - IZ's comment indicates 
> >it
> >may be slow.  If it's too slow, we should drop that chunk of code altogether.
> 
> This cured the problem. Works fine now, both from the main page, and
> using the url as the target when starting lynx. 

It does make IZ's test-case use more memory.  I'l studying it to see what
fix will work.

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden