Re: lynx-dev valgrind

[Leonid Pauzner]

4-Feb-2003 01:26 I wrote:
> 2-Feb-2003 18:08 Thomas Dickey wrote:
>> After adding LP's fixes, I see this problem when testing with valgrind
>> and the no-leaks configuration.  This is if I do something like visit the
>> help page, then another, then the help page again, so it is linked more than
>> once in memory.

>> ==19625== Invalid read of size 4
>> ==19625==    at 0x8110DB6: deleteLinks 
>> (../../../WWW/Library/Implementation/HTAnchor.c:526)

> Yes, I saw this either (crash under gdb).
> Apparently, this is due to
>>>++ HTAnchor_link now links only foreign sources -LP
> - destinations and sources became unbalanced
> (I haven't thought it is so critical).

Oh!  This was an error in HTAnchor_delete vs deleteLinks mutual recursion
logic (from early lynx days, objects were freed at wrong time - too late).

Now fixed.

> I made a patch against your dev13b snapshot,
> it finishes my play around HTAnchor.c/h.


 htanchor.c |  158 +++++++++++++++++++++++++++----------------------------------
 htlist.c   |    8 ++-
 2 files changed, 77 insertions, 89 deletions

dev14a.pat
Description: Binary data