[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev [PATCH 2.8.4dev.18] GridText.c cleanup

From: Ilya Zakharevich
Subject: lynx-dev [PATCH 2.8.4dev.18] GridText.c cleanup
Date: Sun, 25 Feb 2001 01:46:54 -0500
User-agent: Mutt/1.2.5i

This patch does not add any new functionality.  All I did was I went
through more than 1000 lines of extremely badly written obfuscated C code
worthy of a first year CS student...

I managed to remove more than 1/3 of this code, unobfuscate most of
the algorithms I could understand, remove unused structure members,
remove duplicate code chunks, remove duplicate logic, introduce
properly named tmp variables, etc etc etc.  But this is the only a
small fraction of GridText.c, and this file is only a small fraction
of lynx...  Of all the useful software I have seen, lynx definitely
has the worst source code...

The patch takes around 66K, so I hesitate to include it here.  It is

As with any patch of this size, bugs are unevitable.  However, in a
couple of days I use it, it behaves not lest robust than without the patch.
I know the only difference it creates:

Look on the link under IFRAME: without the patch only the first line
is highlighted when active, with the patch both are highlighted
(though the highlighting is "strange").  The corresponding HTML is not
correct.  It looks like this (note that the first <a> is not terminated).

<body style="background: #ffffff; color: #000000;">
<a href="supportus.php3">
<A HREF="ad/click?bfmid=115297&siteid=29479448&size=234x60&space=7407639">



; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]