Re: lynx-dev [PATCH 2.8.3.15] mail on OS/2

[Klaus Weide]

On Thu, 18 Nov 1999, Ilya Zakharevich wrote:

> This patch enables mailto: on OS/2.

What about mailto without this patch - is is disabled?


> --- ./src/LYUtils.c-pre       Wed Nov 17 23:08:08 1999
> +++ ./src/LYUtils.c   Thu Nov 18 02:34:44 1999
> @@ -7149,6 +7149,33 @@ PUBLIC int LYCopyFile ARGS2(
>  #endif
>  }
>  
> +PRIVATE void
> +convert_slash(char **cmd, int *do_free)
> +{
> +#  ifdef __EMX__                     /* FIXME: Should be LY_CONVERT_SLASH? */
> +    /* Configure writes commands which contain direct slashes.
> +       Native command-(non)-shell will not tolerate this. */


This is really perverse.

Configure writes the configuration in a way that (apparently) is not
apporopriate, and the "solution" is to fix it up every single time
such a string is used at run-time??  Why not solve the problem at the
source?  

It seems your LYPopen only gets applied to fixed commands, whose strings
come directly from configuration info.  *There is no need for it* if you
don't use bogus config info in the first place.


   Klaus