lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev CYGWIN patch for dev.14


From: Leonid Pauzner
Subject: Re: lynx-dev CYGWIN patch for dev.14
Date: Mon, 15 Nov 1999 18:37:27 +0300 (MSK)

15-Nov-99 08:57 T.E.Dickey wrote:
>>
>> 15-Nov-99 00:24 Doug Kaufman wrote:
>> > I had a chance to play with dev.14 and CYGWIN. This was the first
>> > time I tried to compile using the WIN_EX define. The following patch
>>
>> That became more and more complicated after TD made his first step
>> into the wrong direction: all this passage in mainloop()
>> should be ifdef'ed with CJK_EX, and without WIN_EX for sure.

> I haven't looked at this closely enough to see the larger picture - do you
> have a better fix in mind?

Well, we will not see any visual effect without SetConsoleTitle()
which is reportedly windows-specific:

 PRIVATE void set_ws_title(char * str)
 {
+#ifdef WIN_EX
     SetConsoleTitle(str);
+#endif /* WIN_EX */
 }


But things would be more consistent
when inlined with the original Hiroyuki 282pre6 patch
(mainloop code in subject was originally ifdefed with SH_EX), so:


diff -u old/lymainlo.c ./lymainlo.c
--- old/lymainlo.c      Thu Nov  4 16:56:06 1999
+++ ./lymainlo.c        Mon Nov 15 18:04:24 1999
@@ -91,7 +91,6 @@
     return buff;
 }

-#ifdef WIN_EX

 PRIVATE char *str_sjis(char *to, char *from)
 {
@@ -109,10 +108,10 @@

 PRIVATE void set_ws_title(char * str)
 {
+#ifdef WIN_EX
     SetConsoleTitle(str);
-}
-
 #endif /* WIN_EX */
+}

 #endif /* CJK_EX */

@@ -4965,11 +4964,10 @@

 int mainloop NOARGS
 {
-#if defined(WIN_EX)    /* 1997/10/08 (Wed) 14:52:06 */
+#if defined(CJK_EX)    /* 1997/10/08 (Wed) 14:52:06 */
 #undef STRING_MAX
 #define        STRING_MAX      4096
     char temp_buff[STRING_MAX];
-
 #define        BUFF_MAX        1024
     char sjis_buff[BUFF_MAX];
 #endif
@@ -6133,7 +6131,7 @@

        }

-#if defined(WIN_EX)                    /* 1997/10/08 (Wed) 14:52:06 */
+#if defined(CJK_EX)                    /* 1997/10/08 (Wed) 14:52:06 */
        if (nlinks > 0) {
            char *p = "LYNX (unknown link type)";

@@ -6199,7 +6197,7 @@
                set_ws_title(HTUnEscape(temp_buff));
            }
        }
-#endif /* WIN_EX */
+#endif /* CJK_EX */

        /*
         *  Report unread or new mail, if appropriate.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]