[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev [PATCH 2.8.3.dev10] Key binding in lynx

From: Klaus Weide
Subject: Re: lynx-dev [PATCH 2.8.3.dev10] Key binding in lynx
Date: Thu, 11 Nov 1999 12:35:12 -0600 (CST)

On Thu, 11 Nov 1999, Ilya Zakharevich wrote:

> > (Your patch is missing comments added to samples/lynx-keymaps.
> > we don't need yet more undocumented keymapping features...)
> Of course.  After "PASS!" is documented.  ;-)

"PASS!" isn't documented because it's probably not very useful, the
documentation would be more confusing than not knowing about it.  It
can only be used in some unusual circumstances that aren't documented
either.  It's there for some sort of completeness, maybe waiting for
someone to find a use for it.

Don't use that as an excuse for not documenting something that is
meant to be generally useful.

> > This should be done at the lynx.cfg KEYMAP level, not at the
> > .lynx-keymaps level.
> Since these levels share parsing code, consider this already done.  ;-)

But it isn't already done, in your patch, as far as I could see.

> Of course, there is an orthogonal issue that the functionality of
> setkey should be available via lynx.cfg (KEYSEQ command?  Extension to
> KEYMAP command?).

Or maybe it shouldn't.  Setkey doesn't make any sense on some systems.
It doesn't work if you don't have USE_KEYMAPS defined.  I don't see why
one *should* have USE_KEYMAPS defined.

> > The LAC: stuff in .lynx-keymaps shouldn't be encouraged
> Highly debatable.  I consider LAC:-less stuff extremely
> counterintuitive.  One should not define keybindings as key--->key, it
> should be key--->action.

Take that up with whoever came up with .lynx-keymaps first...
The good thing is, you don't have to use it.

I revise my statement:
   Using .lynx-keymaps shouldn't be encouraged.

Use termcap / terminfo / infocmp / tic instead.  The LAC:-less stuff
basically just duplicates that functionality, as far as somewhat
"normal" keys are concerned.  The LAC:-full stuff should be in

Use .lynx-keymaps only if you really have to do something unusual
that isn't otherwise possible.

> > I hope you could revise your patch after mine is out, so they can
> > work together...
> Well, my patch *is* out, so I hope you will revise your patch.  ;-)

I was afraid you'd say so...
But <> was
out before your patch, so it's up to you to check against that at least...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]