lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev README.defines additions [patch]


From: Klaus Weide
Subject: Re: lynx-dev README.defines additions [patch]
Date: Thu, 17 Jun 1999 04:27:13 -0500 (CDT)

On Sat, 12 Jun 1999, brian j pardy wrote:

> On Thu, Jun 03, 1999, Klaus Weide wrote:
> > * Updated README.defines.  Other contributors should please add their
> >   stuff there, too.
> 
> Here's a bit more from LYCookie.c.
> 
> (Anyone else think those defines in LYCookie.c better belong in
> LYCookie.h?)

As long as only LYCookie.c uses them, they are fine where they
are IMO.   If we really want to emphasize that they are for
customization, they should be moved to userdefs.h not LYCookie.h.

> diff -ur 2.8.3dev.1/docs/README.defines 2.8.3dev.1.bri/docs/README.defines
> --- 2.8.3dev.1/docs/README.defines    Sat Jun 12 23:39:13 1999
> +++ 2.8.3dev.1.bri/docs/README.defines        Sat Jun 12 23:44:55 1999
> @@ -114,6 +114,7 @@
>  # -DDECLARE_WAIS_LOGFILES   see comments in makefile.in
>  # -DNO_RULES    Disables code for CERN-style rules files
>  # -DHAVE_SIGACTION Can use sigaction() and related functions
> +# -DEXP_PERSISTENT_COOKIES - Enable persistent cookie storage

Not necessary to add this since it's handled by configure
(although, somewhat inconsistently, some of those are listed.)

>  Untested
>  --------
> @@ -135,3 +136,12 @@
>  reverse_mailcap                              HTInit.c
>  ADVANCED_INFO                                LYShowInfo.c
>  CHECK_FREE_MEM                               GridText.c
> +max_cookies_domain                   LYCookie.c
> +max_cookies_global                   LYCookie.c
> +max_cookies_buffer                   LYCookie.c

The above three are useful to add.

> +COOKIE_FLAG_SECURE                   LYCookie.c
> +COOKIE_FLAG_DISCARD                  LYCookie.c
> +COOKIE_FLAG_EXPIRES_SET                      LYCookie.c
> +COOKIE_FLAG_DOMAIN_SET                       LYCookie.c
> +COOKIE_FLAG_PATH_SET                 LYCookie.c
> +COOKIE_FLAG_FROM_FILE                        LYCookie.c

These shouldn't be added - they are just internal constants, not meant
to customize or adjust behaviour in any useful manner.

   Klaus


reply via email to

[Prev in Thread] Current Thread [Next in Thread]