lynx-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lynx-dev lynx2.8.1rel.2 patch


From: Karl-Andre' Skevik
Subject: lynx-dev lynx2.8.1rel.2 patch
Date: 30 Oct 1998 18:16:18 +0100

In lynx2.8.1rel.2, WWW/Library/Implementation/HTFTP.c:

If the function get_listen_socket (line 2576) fails before
master_scoket is set (eg. bacause (R)getsockname fails (line 1067),
FD_CLR will be called while it still contains -1 for which behaviour
is undefined.

Small patch with one possible solution included below.

Karl-Andre' Skevik

*** HTFTP.c     Fri Oct 30 17:49:10 1998
--- HTFTP.c.orig      Thu Aug  6 14:28:22 1998
***************
*** 972,980 ****
  PRIVATE int close_master_socket NOARGS
  {
      int status;
! 
!     if (master_socket != -1) 
!           FD_CLR(master_socket, &open_sockets);
      status = NETCLOSE(master_socket);
      CTRACE(tfp, "HTFTP: Closed master socket %d\n", master_socket);
      master_socket = -1;
--- 972,978 ----
  PRIVATE int close_master_socket NOARGS
  {
      int status;
!     FD_CLR(master_socket, &open_sockets);
      status = NETCLOSE(master_socket);
      CTRACE(tfp, "HTFTP: Closed master socket %d\n", master_socket);
      master_socket = -1;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]