[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev [2.8.1dev.25] patch for LYLoadCookies(), again
From: |
brian j. pardy |
Subject: |
Re: lynx-dev [2.8.1dev.25] patch for LYLoadCookies(), again |
Date: |
Mon, 7 Sep 1998 14:34:08 -0700 |
I wrote:
[patch]
Okay, I need some coffee.
This "int j;" should also be a "char *j;", or it gives a warning at
compiletime.
Sigh.
> --- 1845,1857 ----
> int tok_loop;
> char *tok_values[] = {domain, what, path, secure, expires_a, name,
> value, NULL};
> char *tok_out, *tok_ptr;
> + int j;
+ char *j;
>
> ! j = fgets(buf, 4999, cookie_handle);
> !
> ! if((j == NULL) || (buf[0] == '\0' || buf[0] == '\n')) {
> ! continue;
> ! }
>
> /*
> * Tokenise the cookie line into it's component parts -
I see a memory leak in LYCookie.c in my cookie_add_{accept,reject}list()
functions, I'm going to see if I can get those cleaned up. I promise to
not send out 3 versions of any patch to those, too. :)
I also see this leak:
Memory leak detected.
Pointer: 0x81a20d0
Contains: X ||-|||&|||||||||||||||||||||||||||||||||||||||||
ByteSize: 76
FileName: ../../../WWW/Library/Implementation/HTStyle.c
LineCount: 21
Haven't had a chance to look at that, yet. It looks like the only leaks
right now are this one in HTStyle.c, a couple I added in LYCookie.c, and
one other in LYCookie.c.
--
University politics are vicious precisely because the stakes are so small.
-- Henry Kissinger