Re: [lwip-users] to free or not to free (pbuf_free in tcp_recv)

[address@hidden]

Am 29.01.2019 um 20:08 schrieb address@hidden:
> Am 29.01.2019 um 16:32 schrieb address@hidden:
> > [..]
> > Hi Simon,
> >
> > It's located in File: contrib-2.1.0\apps\tcpecho_raw\tcpecho_raw.c
> > in function tcpecho_raw_recv
> > lines 200 to 247
>
> Oh, right. Don't know why I didn't see that.
>
> Well, I guess that code is not really useful. Currently, the recv
> callback is never called with an 'err' other than ERR_OK, but if it
> would, there would most certainly not be a pbuf, so 'p' would be NULL.
>
> So this is probably a bad example and it might assert instead for 'p' to
> be NULL.

I've just updated the code to assert for "p == NULL" in this case.

Regards,
Simon