Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

[Sylvain Rochet]

Hi,

On Tue, May 16, 2017 at 10:48:26AM +0200, Simon Goldschmidt wrote:
> Marco Jakobs wrote:
> > That one deals with this:
> > 
> > LWIP_ERROR("p_to != NULL", (p_to != NULL) || (p_from == NULL) || 
> > (p_from->len == NULL) , return ERR_ARG;);
> 
> WTF? "-len == NULL"???
> 
> > The assert comes from the ICMP routine ;-) :
> 
> I rather guess the bug is in PPP (from 1.4.1) allocating a pbuf with 
> len==0 at the end. Otherwise, you should see this bug on the ethernet 
> side, too.

I checked if the issue was still there is the current master/2.0 branch, 
you are right, this bug was fixed in commit fb07a28c99 ("fixed bug 
#36388 (PPP: checksum-only in last pbuf leads to pbuf with zero 
length)") *FIVE* years ago.

Sylvain

signature.asc
Description: Digital signature